prevent php errors for potentially uninitialised var

11 years ago · cdfbeeb1d2
2 changed files with 5 additions and 5 deletions
--- a/main.php
+++ b/main.php
@ -11,7 +11,7 @@ if (!defined('DOKU_INC')) die(); /* must be run from within DokuWiki */
@require_once(dirname(__FILE__).'/tpl_functions.php'); /* include hook for template functions */
 header('X-UA-Compatible: IE=edge,chrome=1');

-$showTools = !tpl_getConf('hideTools') || ( tpl_getConf('hideTools') && $_SERVER['REMOTE_USER'] );
+$showTools = !tpl_getConf('hideTools') || ( tpl_getConf('hideTools') && !empty($_SERVER['REMOTE_USER']) );
 $showSidebar = page_findnearest($conf['sidebar']) && ($ACT=='show');
 ?><!DOCTYPE html>
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php echo $conf['lang'] ?>"
@ -65,7 +65,7 @@ $showSidebar = page_findnearest($conf['sidebar']) && ($ACT=='show');
                        <ul>
                            <?php /* the optional second parameter of tpl_action() switches between a link and a button,
                                     e.g. a button inside a <li> would be: tpl_action('edit', 0, 'li') */
-                                if ($_SERVER['REMOTE_USER']) {
+                                if (!empty($_SERVER['REMOTE_USER'])) {
                                    echo '<li class="user">';
                                    tpl_userinfo(); /* 'Logged in as ...' */
                                    echo '</li>';
--- a/tpl_functions.php
+++ b/tpl_functions.php
@ -47,7 +47,7 @@ function _tpl_discussion($discussionPage, $title, $backTitle, $link=0, $wrapper=
 * @author Anika Henke <anika@selfthinker.org>
 */
 function _tpl_userpage($userPage, $title, $link=0, $wrapper=0) {
-    if (!$_SERVER['REMOTE_USER']) return;
+    if (empty($_SERVER['REMOTE_USER'])) return;

    global $conf;
    $userPage = str_replace('@USER@', $_SERVER['REMOTE_USER'], $userPage);
@ -74,7 +74,7 @@ function _tpl_register($link=0, $wrapper=0) {
    global $ID;
    $lang_register = !empty($lang['btn_register']) ? $lang['btn_register'] : $lang['register'];

-    if ($_SERVER['REMOTE_USER'] || !$conf['useacl'] || !actionOK('register')) return;
+    if (!empty($_SERVER['REMOTE_USER']) || !$conf['useacl'] || !actionOK('register')) return;

    if ($wrapper) echo "<$wrapper>";

@ -265,7 +265,7 @@ if (!function_exists('tpl_classes')) {
            'dokuwiki',
            'mode_'.$ACT,
            'tpl_'.$conf['template'],
-            $_SERVER['REMOTE_USER'] ? 'loggedIn' : '',
+            !empty($_SERVER['REMOTE_USER']) ? 'loggedIn' : '',
            $INFO['exists'] ? '' : 'notFound',
            ($ID == $conf['start']) ? 'home' : '',
        );