Change log passing

src/loggers.rs

@@ -7,7 +7,7 @@ use std::io::Write;
 // 1 - Error, 2 - Warn, 3 - Info, 4 - Debug, 5 - Trace
 pub type Level = usize;
 
-#[derive(Debug)]
+#[derive(Clone, Debug)]
 pub struct Entry<S>(pub Level, pub S);
 
 pub trait Logger {
@@ -67,7 +67,7 @@ impl Logger for StdErrLogger {
 }
 impl Drop for StdErrLogger {
   fn drop(&mut self) {
-    if *self.line_started.borrow() == true {
+    if *self.line_started.borrow() {
       writeln!(&mut stderr()).unwrap();
     }
   }
@@ -98,7 +98,7 @@ impl<'a, L: Logger> Logger for FilteringLogger<'a, L> {
   }
 }
 
-#[derive(Debug, Default)]
+#[derive(Clone, Debug, Default)]
 pub struct StoringLogger {
   log: RefCell<(bool, Vec<Entry<String>>)>,
 }
@@ -125,6 +125,7 @@ impl Logger for StoringLogger {
       None
     }
     .unwrap_or_else(|| Entry(level, line.into()));
+    log.0 = true;
     log.1.push(entry);
   }
   fn writeln<S: AsRef<str> + Into<String>>(&self, level: Level, line: S) {

src/setup/core.rs

@@ -1,6 +1,6 @@
 use super::runnable::Runnable;
-use super::util::{AddResult, AddableResource};
+use super::setup::Setup;
-use super::Setup;
+use super::util::{AddableResource, InternalAddResult};
 use super::SymbolRunner;
 use crate::async_utils::try_join;
 use crate::loggers::{Logger, StoringLogger};
@@ -16,15 +16,15 @@ use std::marker::PhantomData;
 
 #[async_trait(?Send)]
 pub trait AddGeneric<X: ToArtifact> {
-  async fn add_generic(&self, x: X) -> AddResult<X>;
+  async fn add_generic(&self, x: X) -> InternalAddResult<X>;
 }
 
 macro_rules! add_generic {
   ( $($name:ident)* ) => (
     #[async_trait(?Send)]
     #[allow(non_snake_case)]
-    impl<SR: 'static, _L: 'static, _B: 'static, LOG: 'static + Logger, Rs: 'static + Hash + Eq, As: 'static + Clone, $($name: AddableResource,)*>
+    impl<SR: 'static, _L: 'static, _B: 'static, Rs: 'static + Hash + Eq, As: 'static + Clone, $($name: AddableResource,)*>
-      AddGeneric<($($name,)*)> for Setup<SR, LOG, _L, _B, Rs, As>
+      AddGeneric<($($name,)*)> for Setup<SR, _L, _B, Rs, As>
       where
       $(
         RegularSetupCore<SR, _L, _B>: SetupCore<$name, Self>,
@@ -34,11 +34,13 @@ macro_rules! add_generic {
       ),*
     {
       #[allow(unused)]
-      async fn add_generic(&self, ($($name,)*): ($($name,)*)) -> Result<(($($name::Artifact,)*), bool), Box<dyn Error>>
+      async fn add_generic(&self, ($($name,)*): ($($name,)*)) -> Result<(StoringLogger, ($($name::Artifact,)*), bool), (StoringLogger, Box<dyn Error>)>
       {
-        let x: Result<_, Box<dyn Error>> = try_join!($(self.add_force($name, false),)*);
+        let x: Result<_, _> = try_join!($(self.add($name, false),)*);
         let ($($name,)*) = x?;
-        Ok((($($name.0,)*), false $(|| $name.1)*))
+        let logger = StoringLogger::default();
+        $(logger.put($name.0.release());)*
+        Ok((logger, ($($name.1,)*), false $(|| $name.2)*))
       }
     }
   );
@@ -51,57 +53,54 @@ for_each_tuple!(add_generic);
 #[async_trait(?Send)]
 impl<
     SR: 'static + SymbolRunner,
-    LOG: 'static + Logger,
     T: AddableResource,
     Rs: 'static + Hash + Eq + FromResource<T>,
     As: 'static + FromArtifact<T> + Clone,
     L: 'static + ResourceLocator<T, Prerequisites = Option<T>>,
     B: 'static + ImplementationBuilder<T>,
-  > AddGeneric<Option<T>> for Setup<SR, LOG, L, B, Rs, As>
+  > AddGeneric<Option<T>> for Setup<SR, L, B, Rs, As>
 where
   <B as ImplementationBuilder<T>>::Implementation: Runnable + Debug,
   Self: AddGeneric<B::Prerequisites>,
   T::Artifact: Clone,
 {
-  async fn add_generic(&self, r: Option<T>) -> AddResult<Option<T>> {
+  async fn add_generic(&self, r: Option<T>) -> InternalAddResult<Option<T>> {
     Ok(match r {
       Some(r) => {
-        let (result, did_run) = self.add_force(r, false).await?;
+        let (logger, result, did_run) = self.add(r, false).await?;
-        (Some(result), did_run)
+        (logger, Some(result), did_run)
       }
-      None => (None, false),
+      None => (StoringLogger::default(), None, false),
     })
   }
 }
 
 #[async_trait(?Send)]
 impl<
-    LOG: 'static + Logger,
     T: AddableResource,
     Rs: 'static + Hash + Eq + FromResource<T>,
     As: 'static + FromArtifact<T> + Clone,
     SR: 'static,
     L: 'static,
     B: 'static,
-  > AddGeneric<T> for Setup<SR, LOG, L, B, Rs, As>
+  > AddGeneric<T> for Setup<SR, L, B, Rs, As>
 where
   T::Artifact: Clone,
   RegularSetupCore<SR, L, B>: 'static + SetupCore<T, Self>,
 {
-  async fn add_generic(&self, r: T) -> AddResult<T> {
+  async fn add_generic(&self, r: T) -> InternalAddResult<T> {
-    self.add_force(r, false).await
+    self.add(r, false).await
   }
 }
 
 #[async_trait(?Send)]
 pub trait SetupCore<R: AddableResource, S> {
-  async fn add<LOG: Logger, RR: AsRef<R>>(
+  async fn add<RR: AsRef<R>>(
     &self,
     setup: &S,
-    parent_logger: &LOG,
     resource: RR,
     force_run: bool,
-  ) -> AddResult<R>;
+  ) -> InternalAddResult<R>;
 }
 
 #[derive(Debug)]
@@ -127,49 +126,57 @@ where
   L: ResourceLocator<R>,
   S: AddGeneric<B::Prerequisites> + AddGeneric<<L as ResourceLocator<R>>::Prerequisites>,
 {
-  async fn add<LOG: Logger, RR: AsRef<R>>(
+  async fn add<RR: AsRef<R>>(
     &self,
     setup: &S,
-    parent_logger: &LOG,
     resource: RR,
     force_run: bool,
-  ) -> AddResult<R> {
+  ) -> InternalAddResult<R> {
     let resource = resource.as_ref();
     let logger = StoringLogger::new();
     logger.write(4, format!("Adding {:?} ... ", resource));
-    let result = async {
+    logger.write(4, format!("(force_run is {})", force_run));
-      logger.trace(format!(" (force_run is {})", force_run));
+    let (location, location_prereqs) = L::locate(resource);
-      let (location, location_prereqs) = L::locate(resource);
+    logger.trace(format!("Adding location prereqs for {:?}", resource));
-      logger.trace(format!("Adding location prereqs for {:?}", resource));
+    let result = setup.add_generic(location_prereqs).await;
-      let (_, location_prereqs_did_run) = setup.add_generic(location_prereqs).await?;
+    if let Err((log, e)) = result {
-      logger.trace(format!(
+      logger.put(log.release());
-        "Location prereqs for {:?} did_run: {}",
+      return Err((logger, e));
-        resource, location_prereqs_did_run
-      ));
-      logger.trace(format!("Adding implementation prereqs for {:?}", resource));
-      let (prereqs, prereqs_did_run) = setup.add_generic(B::prerequisites(resource)).await?;
-      logger.trace(format!(
-        "Implementation prereqs for {:?} did_run: {}",
-        resource, prereqs_did_run
-      ));
-      logger.trace(format!("Running implementation for {:?}", resource));
-      let implementation = B::create(resource, &location, prereqs);
-      let did_run = implementation
-        .run(
-          &self.symbol_runner,
-          &logger,
-          force_run || location_prereqs_did_run || prereqs_did_run,
-        )
-        .await?;
-      Ok((location, did_run))
     }
-    .await;
+    let (location_prereq_logger, _, location_prereqs_did_run) = result.unwrap();
-    logger.write(4, "done.");
+    logger.put(location_prereq_logger.release());
-    let max_level = if result.is_err() { 5 } else { 3 };
+    logger.trace(format!(
-    if parent_logger.put(logger.release().into_iter().filter(|e| e.0 <= max_level)) == 0 {
+      "Location prereqs for {:?} did_run: {}",
-      parent_logger.write(3, ".");
+      resource, location_prereqs_did_run
+    ));
+    logger.trace(format!("Adding implementation prereqs for {:?}", resource));
+    let result = setup.add_generic(B::prerequisites(resource)).await;
+    if let Err((log, e)) = result {
+      logger.put(log.release());
+      return Err((logger, e));
+    }
+    let (impl_prereq_logger, prereqs, prereqs_did_run) = result.unwrap();
+    logger.put(impl_prereq_logger.release());
+    logger.trace(format!(
+      "Implementation prereqs for {:?} did_run: {}",
+      resource, prereqs_did_run
+    ));
+    logger.trace(format!("Running implementation for {:?}", resource));
+    let implementation = B::create(resource, &location, prereqs);
+    let did_run_result = implementation
+      .run(
+        &self.symbol_runner,
+        &logger,
+        force_run || location_prereqs_did_run || prereqs_did_run,
+      )
+      .await;
+    match did_run_result {
+      Ok(did_run) => {
+        logger.write(4, "done.");
+        Ok((logger, location, did_run))
+      }
+      Err(e) => Err((logger, e)),
     }
-    result
   }
 }
 

src/setup/mod.rs

@@ -8,4 +8,4 @@ pub use symbol_runner::{
 };
 mod runnable;
 mod setup;
-pub use setup::Setup;
+pub use setup::SetupFacade as Setup;

src/setup/setup.rs

@@ -1,8 +1,9 @@
 use super::core::{RegularSetupCore, SetupCore};
 use super::runnable::Runnable;
-use super::util::{AddResult, AddableResource};
+use super::util::{AddResult, AddableResource, InternalAddResult};
 use super::SymbolRunner;
-use crate::loggers::Logger;
+use crate::async_utils::sleep;
+use crate::loggers::{Logger, StoringLogger};
 use crate::resources::{DefaultArtifacts, DefaultResources, FromArtifact, FromResource};
 use crate::{DefaultBuilder, DefaultLocator};
 use futures::future::FutureExt;
@@ -14,57 +15,27 @@ use std::future::Future;
 use std::hash::Hash;
 use std::pin::Pin;
 use std::rc::Rc;
+use std::time::Duration;
 
 type Cache<Rs, As> = HashMap<Rs, Shared<Pin<Box<dyn Future<Output = (As, bool)>>>>>;
 
 #[derive(Debug)]
-struct SetupInner<CORE, LOG, Rs, As> {
+struct SetupInner<CORE, Rs, As> {
   core: CORE,
-  logger: LOG,
   resources: RefCell<Cache<Rs, As>>,
 }
 
 #[derive(Debug)]
-pub struct Setup<
+pub struct Setup<SR, L, B, Rs, As>(Rc<SetupInner<RegularSetupCore<SR, L, B>, Rs, As>>);
-  SR,
-  LOG,
-  L = DefaultLocator,
-  B = DefaultBuilder,
-  Rs = DefaultResources<'static, &'static str>,
-  As = DefaultArtifacts<'static, &'static str>,
->(Rc<SetupInner<RegularSetupCore<SR, L, B>, LOG, Rs, As>>);
 
-// https://github.com/rust-lang/rust/issues/27336
+impl<L: 'static, B: 'static, SR: 'static, Rs: Hash + Eq + 'static, As: 'static>
-impl<SR, LOG> Setup<SR, LOG> {
+  Setup<SR, L, B, Rs, As>
-  pub fn new(symbol_runner: SR, logger: LOG) -> Self {
-    Self::new_with(symbol_runner, logger)
-  }
-}
-
-impl<L, B, As, SR, LOG, Rs: Hash + Eq> Setup<SR, LOG, L, B, Rs, As> {
-  pub fn new_with(symbol_runner: SR, logger: LOG) -> Self {
-    Self(Rc::new(SetupInner {
-      core: RegularSetupCore::new(symbol_runner),
-      logger,
-      resources: RefCell::default(),
-    }))
-  }
-}
-
-impl<
-    L: 'static,
-    B: 'static,
-    SR: 'static,
-    LOG: 'static + Logger,
-    Rs: Hash + Eq + 'static,
-    As: 'static,
-  > Setup<SR, LOG, L, B, Rs, As>
 {
   fn borrow_resources(&self) -> RefMut<'_, Cache<Rs, As>> {
     self.0.resources.borrow_mut()
   }
 
-  pub async fn add_force<R: AddableResource>(&self, resource: R, force_run: bool) -> AddResult<R>
+  pub async fn add<R: AddableResource>(&self, resource: R, force_run: bool) -> InternalAddResult<R>
   where
     Rs: FromResource<R>,
     As: FromArtifact<R> + Clone,
@@ -73,51 +44,123 @@ impl<
   {
     let (storable_resource, weak_resource) = Rs::from_resource(resource);
     let mut resources = self.borrow_resources();
-    if let Some(future) = resources.remove(&storable_resource) {
+    let result = if let Some(future) = resources.remove(&storable_resource) {
       assert!(
         !force_run,
         "Forcing to run an already-added resource is a logical error"
       );
       resources.insert(storable_resource, future.clone());
       drop(resources);
-      Ok(future.await)
+      let logger = StoringLogger::default();
+      logger.trace(format!(
+        "{:?} already added",
+        weak_resource.upgrade().expect("Dangling!")
+      ));
+      let (t, did_run) = future.await;
+      Ok((logger, t, did_run))
     } else {
       let inner_weak = Rc::downgrade(&self.0);
       let future = Box::pin(async move {
         let this = Self(inner_weak.upgrade().expect("Dangling!"));
         let resource = weak_resource.upgrade().expect("Dangling!");
         // Need to convert Box<Error> to String for Clone for Shared
-        this
+        let result = this.0.core.add(&this, resource, force_run).await;
-          .0
+
-          .core
+        result
-          .add(&this, &this.0.logger, resource, force_run)
+          .map(|(logger, t, did_run)| (logger, As::from_artifact(t), did_run))
-          .await
+          .map_err(|(logger, e)| (logger, e.to_string()))
-          .map(|(t, did_run)| (As::from_artifact(t), did_run))
-          .map_err(|e| e.to_string())
       })
       .shared();
       let future_clone = future.clone();
       resources.insert(
         storable_resource,
-        (Box::pin(async move { future_clone.await.unwrap() })
+        (Box::pin(async move {
-          as Pin<Box<dyn Future<Output = (As, bool)>>>)
+          let result = future_clone.await;
+          if result.is_err() {
+            // Step back to give the initial caller time to handle the error before unwrapping
+            sleep(Duration::from_millis(0)).await;
+          }
+          result.map(|(_, t, did_run)| (t, did_run)).unwrap()
+        }) as Pin<Box<dyn Future<Output = (As, bool)>>>)
           .shared(),
       );
       drop(resources);
-      future.await.map_err(|e| e.into())
+      let result = future.await;
-    }
+      result.map_err(|(logger, e)| (logger, e.into()))
-    .map(|(t, did_run)| (t.into_artifact(), did_run))
+    };
+    result.map(|(logger, t, did_run)| (logger, t.into_artifact(), did_run))
   }
+}
 
-  //
+#[derive(Debug)]
-  // Legacy
+pub struct SetupFacade<
-  //
+  SR,
-  pub async fn add<R: AddableResource>(&self, resource: R) -> AddResult<R>
+  LOG,
+  L = DefaultLocator,
+  B = DefaultBuilder,
+  Rs = DefaultResources<'static, &'static str>,
+  As = DefaultArtifacts<'static, &'static str>,
+>(LOG, Setup<SR, L, B, Rs, As>);
+
+impl<SR, LOG> SetupFacade<SR, LOG> {
+  pub fn new(symbol_runner: SR, logger: LOG) -> Self {
+    Self::new_with(symbol_runner, logger)
+  }
+}
+
+impl<L, B, As, SR, LOG, Rs: Hash + Eq> SetupFacade<SR, LOG, L, B, Rs, As> {
+  pub fn new_with(symbol_runner: SR, logger: LOG) -> Self {
+    Self(
+      logger,
+      Setup(Rc::new(SetupInner {
+        core: RegularSetupCore::new(symbol_runner),
+        resources: RefCell::default(),
+      })),
+    )
+  }
+}
+
+impl<
+    SR: 'static,
+    LOG: 'static + Logger,
+    L: 'static,
+    B: 'static,
+    Rs: 'static + Eq + Hash,
+    As: 'static,
+  > SetupFacade<SR, LOG, L, B, Rs, As>
+{
+  pub async fn add_force<R: AddableResource>(&self, resource: R, force_run: bool) -> AddResult<R>
   where
-    RegularSetupCore<SR, L, B>: SetupCore<R, Self>,
     Rs: FromResource<R>,
     As: FromArtifact<R> + Clone,
     R::Artifact: Clone,
+    RegularSetupCore<SR, L, B>: SetupCore<R, Setup<SR, L, B, Rs, As>>,
+  {
+    let result = self.1.add(resource, force_run).await;
+    match result {
+      Ok((logger, t, did_run)) => {
+        if self
+          .0
+          .put(logger.release().into_iter().filter(|e| e.0 <= 3))
+          == 0
+        {
+          self.0.write(3, ".");
+        }
+        Ok((t, did_run))
+      }
+      Err((logger, e)) => {
+        self.0.put(logger.release());
+        Err(e)
+      }
+    }
+  }
+  pub async fn add<R: AddableResource>(&self, resource: R) -> AddResult<R>
+  where
+    RegularSetupCore<SR, L, B>: SetupCore<R, Setup<SR, L, B, Rs, As>>,
+    Rs: FromResource<R>,
+    As: FromArtifact<R> + Clone,
+    R::Artifact: Clone,
+    SR: SymbolRunner,
   {
     self.add_force(resource, false).await
   }
@@ -130,7 +173,7 @@ impl<
   where
     RegularSetupCore<SR, L, B>: SymbolRunner,
   {
-    symbol.run(&self.0.core, &self.0.logger, force).await
+    symbol.run(&(self.1).0.core, &self.0, force).await
   }
 }
 

src/setup/util.rs

@@ -1,3 +1,4 @@
+use crate::loggers::StoringLogger;
 use crate::resources::Resource;
 use crate::to_artifact::ToArtifact;
 use std::error::Error;
@@ -7,3 +8,5 @@ pub trait AddableResource: 'static + Resource + Debug {}
 impl<R> AddableResource for R where R: 'static + Resource + Debug {}
 
 pub type AddResult<R> = Result<(<R as ToArtifact>::Artifact, bool), Box<dyn Error>>;
+pub type InternalAddResult<R> =
+  Result<(StoringLogger, <R as ToArtifact>::Artifact, bool), (StoringLogger, Box<dyn Error>)>;