Clippy

src/setup/core.rs

@@ -33,7 +33,7 @@ macro_rules! add_generic {
         $name::Artifact: Clone
       ),*
     {
-      #[allow(unused)]
+      #[allow(unused, clippy::shadow_unrelated)]
       async fn add_generic(&self, ($($name,)*): ($($name,)*)) -> Result<(StoringLogger, ($($name::Artifact,)*), bool), (StoringLogger, Box<dyn Error>)>
       {
         let ($($name,)*) = join!($(self.add($name, false),)*);

src/setup/setup.rs

@@ -34,6 +34,8 @@ impl<L: 'static, B: 'static, SR: 'static, Rs: Hash + Eq + 'static, As: 'static>
     self.0.resources.borrow_mut()
   }
 
+  // FIXME: https://github.com/rust-lang/rust-clippy/issues/6353
+  #[allow(clippy::await_holding_refcell_ref)]
   pub async fn add<R: AddableResource>(&self, resource: R, force_run: bool) -> InternalAddResult<R>
   where
     Rs: FromResource<R>,

src/setup/symbol_runner.rs

@@ -101,6 +101,11 @@ impl<R> SymbolRunner for DelayingSymbolRunner<R>
 where
   R: SymbolRunner,
 {
+  #[allow(
+    clippy::cast_sign_loss,
+    clippy::cast_possible_truncation,
+    clippy::cast_precision_loss
+  )]
   async fn run_symbol<S: Symbol + Debug, L: Logger>(
     &self,
     symbol: &S,
@@ -182,9 +187,9 @@ where
     logger.debug(format!("Running symbol {:?}", symbol));
     let res = self.0.run_symbol(symbol, logger, force).await;
     if let Err(ref e) = res {
-      logger.info(format!("Failed on {:?} with {}, aborting.", symbol, e))
+      logger.info(format!("Failed on {:?} with {}, aborting.", symbol, e));
     } else {
-      logger.debug(format!("Successfully finished {:?}", symbol))
+      logger.debug(format!("Successfully finished {:?}", symbol));
     }
     res
   }